fix(thundermail): redirecting to thundermail screen shown when oAuth is cancelled#11045
Merged
rafaeltonholo merged 8 commits intoMay 29, 2026
Conversation
rafaeltonholo
added
the
report: exclude
github-actions
Bot
added
the
tb-team
rafaeltonholo
force-pushed
the
fix/thundermail-redirect-page-issues
branch
from
298cf13 to
3390f88
Compare
wmontwe
requested changes
May 28, 2026
Member
wmontwe
left a comment
wmontwe
left a comment
There was a problem hiding this comment.
LGTM
Just remove the state logging.
…rate file - Add error handling UI with back navigation support - Display error messages for canceled and unknown errors - Show loading state during OAuth redirect
- Add BrowserNotAvailable error state to AccountOAuthContract and ThundermailContract - Catch ActivityNotFoundException when launching OAuth custom tabs - Map OAuth error states to Thundermail error states in ThundermailOAuthViewModel - Display user-friendly error message when browser is unavailable - Add @stable and @immutable annotations to Thundermail contract classes
- Add preview with multiple error states (BrowserNotAvailable, Canceled, Unknown) - Extract ThundermailOAuthRedirectScreen composable for preview support - Improve layout with consistent horizontal padding - Extract RedirectingUserContent into separate composable
- Move ViewModel parameter to end following Compose guidelines - Extract hardcoded error strings to string resources for localization
- Add BrowserNotAvailable error state to AccountOAuthContract and ThundermailContract - Catch ActivityNotFoundException when launching OAuth custom tabs - Map OAuth error states to Thundermail error states in ThundermailOAuthViewModel - Display user-friendly error message when browser is unavailable - Add @stable and @immutable annotations to Thundermail contract classes
rafaeltonholo
force-pushed
the
fix/thundermail-redirect-page-issues
branch
from
3390f88 to
00f2c39
Compare
Member
Author
Thanks for the review @wmontwe! I've removed the log and addressed the other comments as well. Please take a look again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11043.
ThundermailOAuthRedirectScreencomposable for preview supportRedirectingUserContentinto a separate composableBrowserNotAvailableerror state toAccountOAuthContractandThundermailContractActivityNotFoundExceptionwhen launching OAuth custom tabsThundermailOAuthViewModel